New resource type: azurerm_redis_linked_server #8026
Conversation
- Completed with documentation, and tests. I am willing to change the name to geo location to match the portal. For issue hashicorp#3294
There was a problem hiding this comment.
Thanks for this PR @pearcec,
Overall it looks good but i do wonder if we can improve upon the API naming, if the order of server maters src/dest, target, ect might be better as linked isn't very clear what server is receiving the role?
| for { | ||
| time.Sleep(1 * time.Minute) | ||
| resp, err := client.Get(ctx, resourceGroup, redisCacheName, name) |
There was a problem hiding this comment.
Could we use a wait for state function like above as this could never finish
There was a problem hiding this comment.
Yes definitely. I was confused. I misread a comment in Slack and thought I needed futures for this. I reread the comment. Now I understand. This would be a better solution. Testing it now.
azurerm/internal/services/redis/tests/resource_arm_redis_linked_server_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/redis/resource_arm_redis_linked_server.go
Outdated
Show resolved
Hide resolved
…d_server_test.go Co-authored-by: kt <[email protected]>
Co-authored-by: kt <[email protected]>
|
This has been released in version 2.23.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.23.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
to change the name to geo location to match the portal.
For issue #3294
fixes #3294